hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11693) Ozone: Add archive support to containers
Date Fri, 05 May 2017 00:02:04 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anu Engineer updated HDFS-11693:
--------------------------------
    Attachment: HDFS-11693-HDFS-7240.002.patch

[~xyao] and [~cheersyang] Thanks for the reviews. This new patch fixes all issues.
Detailed comments inline 

bq. Can we reuse the FileUtil#unZip and just add zip directory as part of FileUtil?
Fixed, however I needed to add a new function and make the old one call into it. Since I needed
the checksums from zip functions. This is a public interface, so changed my definitions to
match existing code.

bq. Line 46: NIT: BUFFER->BUFFER_SIZE
Fixed.
bq. Can we define a new configuration key like hadoop.ozone.temp.dir
Removed dependency on these settings.
bq. If we do, can we add test cases for directory/subdir/files in addition
Added subdirectories in the test.
bq. Do we want to flush() before the outputstream is closed?
Fixed.
bq. BUFFER->BUFFER_SIZE
Fixed.
bq. destPath.getParent() can be replace with parent
Fixed.

bq.  this can be wrapped as a test util for reuse. 
Not sure if you meant the files creation for compression purpose.

bq. line 69 and line 80 throws rumtime exceptions
Fixed, Now throwing IOExceptions.

bq. I don't think it is necessary to log an error since it throws an exception with the same
error message here
Fixed.

bq. seems we are going to continue with next entry.. does that mean the extracted file is
corrupted
The idea was that checksum will tell us that extraction failed. But now made it throw and
abort the extraction if we get partial failures.

> Ozone: Add archive support to containers
> ----------------------------------------
>
>                 Key: HDFS-11693
>                 URL: https://issues.apache.org/jira/browse/HDFS-11693
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-11693-HDFS-7240.001.patch, HDFS-11693-HDFS-7240.002.patch
>
>
> Add archive support to containers. This is a stepping stone to supporting copy containers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message