hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11680) Ozone: SCM CLI: Implement info container command
Date Sat, 06 May 2017 13:48:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999436#comment-15999436
] 

Weiwei Yang commented on HDFS-11680:
------------------------------------

Hi [~yuanbo]

Thanks for working on this. Patch overall looks good, see some comments below

*ContainerManagerImpl*

line 472: why we should generate the hash value when creating a container? Currently the design
seems to set that when closing a container, because it uses name+timestamp digest. This seems
to imply a change to the design. 

line 476: It utilizes the {{ContainerReport}} for infoContainer, however it was for closed
containers for the first place. This seems to change the semantic of {{ContainerReport}}.
Can we just use {{ContainerInfo}} instead?

line 478: I don't think {{containerData.getAllMetadata().size()}} returns the key count, could
you please double check.

*ContainerOperationClient*

line 167: I don't think you need to wrap log message to {{logPiplineInfo}}, that prints "Deleted...".

*ContainerReport*

line 42: Like commented upon, please revisit this.

*ScmClient*

line 63: Better to doc as "Returns the info of an existing container."

*StorageContainerDatanodeProtocol.proto*

why message {{ContainerInfo}} is removed?

*TestSCMCli*

Can we use {{runCommandAndGetOutput}} to run the command and get the output for comparison?
Can we add a test case when user gives a non-exist container?

And besides of this, could you please attach the test result that from commandline to demonstrate
how this works?

Thanks. 


> Ozone: SCM CLI: Implement info container command
> ------------------------------------------------
>
>                 Key: HDFS-11680
>                 URL: https://issues.apache.org/jira/browse/HDFS-11680
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Yuanbo Liu
>              Labels: command-line
>         Attachments: HDFS-11680-HDFS-7240.001.patch
>
>
> Implement info container
> {code}
> hdfs scm -container info <container name>
> {code}
> Returns information about a specific container.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message