Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 28 Apr 2017 15:49:04 +0000 (UTC)
From: "Erik Krogen (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13067243.1493269606000.79949.1493394544206@Atlassian.JIRA>
In-Reply-To: <JIRA.13067243.1493269606000@Atlassian.JIRA>
References: <JIRA.13067243.1493269606000@Atlassian.JIRA> <JIRA.13067243.1493269606609@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11709) StandbyCheckpointer should handle
 an non-existing legacyOivImageDir gracefully
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 28 Apr 2017 15:49:08 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989050#comment-15989050 ] 

Erik Krogen commented on HDFS-11709:
------------------------------------

[~shv], sure. Filed HDFS-11717.

> StandbyCheckpointer should handle an non-existing legacyOivImageDir gracefully
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-11709
>                 URL: https://issues.apache.org/jira/browse/HDFS-11709
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, namenode
>    Affects Versions: 2.6.1
>            Reporter: Zhe Zhang
>            Assignee: Erik Krogen
>            Priority: Critical
>             Fix For: 2.9.0, 2.7.4, 3.0.0-alpha3, 2.8.1
>
>         Attachments: HDFS-11709.000.patch
>
>
> In {{StandbyCheckpointer}}, if the legacy OIV directory is not properly created, or was deleted for some reason (e.g. mis-operation), all checkpoint ops will fall. Not only the ANN won't receive new fsimages, the JNs will get full with edit log files, and cause NN to crash.
> {code}
>       // Save the legacy OIV image, if the output dir is defined.
>       String outputDir = checkpointConf.getLegacyOivImageDir();
>       if (outputDir != null && !outputDir.isEmpty()) {
>         img.saveLegacyOIVImage(namesystem, outputDir, canceler);
>       }
> {code}
> It doesn't make sense to let such an unimportant part (saving OIV) abort all checkpoints and cause NN crash (and possibly lose data).


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org