Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 24 Apr 2017 17:51:04 +0000 (UTC)
From: "Chen Liang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13061728.1491397382000.35039.1493056264169@Atlassian.JIRA>
In-Reply-To: <JIRA.13061728.1491397382000@Atlassian.JIRA>
References: <JIRA.13061728.1491397382000@Atlassian.JIRA> <JIRA.13061728.1491397382028@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11627) Block Storage: Cblock cache should
 register with flusher to upload blocks to containers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 24 Apr 2017 17:51:09 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981573#comment-15981573 ] 

Chen Liang commented on HDFS-11627:
-----------------------------------

Thanks [~msingh] for working on this. v001 patch looks good to me, one minor comment though, is there a particular reason of using {{LOG.error}} like the following? 
{code}
LOG.error("read failed for BlockId:" + blockID, ex);
{code}
I think the format such as
{code}
LOG.error("read failed for BlockId: {}", blockID, ex);
{code}
is in general slightly better performance-wise.


> Block Storage: Cblock cache should register with flusher to upload blocks to containers
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-11627
>                 URL: https://issues.apache.org/jira/browse/HDFS-11627
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>         Attachments: HDFS-11627-HDFS-7240.001.patch
>
>
> Cblock cache should register with flusher to upload blocks to containers.
> Currently Container Cache flusher tries to write to the container even when the CblockLocalCache pipelines are not registered with the flusher. 
> This will result in the Container writes to fail.
> CblockLocalCache should register with the flusher before accepting any blocks for write


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org