Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 03040200C6B for ; Tue, 18 Apr 2017 01:46:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 01B2E160BB0; Mon, 17 Apr 2017 23:46:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 49FBF160BAB for ; Tue, 18 Apr 2017 01:46:45 +0200 (CEST) Received: (qmail 64329 invoked by uid 500); 17 Apr 2017 23:46:44 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 64318 invoked by uid 99); 17 Apr 2017 23:46:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Apr 2017 23:46:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0EA26C32CD for ; Mon, 17 Apr 2017 23:46:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Kj-b3Ap34OqF for ; Mon, 17 Apr 2017 23:46:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 393BD5FBB0 for ; Mon, 17 Apr 2017 23:46:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ABBDAE0D5B for ; Mon, 17 Apr 2017 23:46:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 00BAC21B52 for ; Mon, 17 Apr 2017 23:46:42 +0000 (UTC) Date: Mon, 17 Apr 2017 23:46:42 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11615) FSNamesystemLock metrics can be inaccurate due to millisecond precision MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Apr 2017 23:46:46 -0000 [ https://issues.apache.org/jira/browse/HDFS-11615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971828#comment-15971828 ] Hudson commented on HDFS-11615: ------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11595 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11595/]) HDFS-11615. FSNamesystemLock metrics can be inaccurate due to (zhz: rev ad49098eb324e238d97db68d7239ed2c4d84afa0) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystemLock.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystemLock.java > FSNamesystemLock metrics can be inaccurate due to millisecond precision > ----------------------------------------------------------------------- > > Key: HDFS-11615 > URL: https://issues.apache.org/jira/browse/HDFS-11615 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 2.7.4 > Reporter: Erik Krogen > Assignee: Erik Krogen > Attachments: HDFS-11615.000.patch, HDFS-11615.001.patch > > > Currently the {{FSNamesystemLock}} metrics created in HDFS-10872 track the lock hold time using {{Timer.monotonicNow()}}, which has millisecond-level precision. However, many of these operations hold the lock for less than a millisecond, making these metrics inaccurate. We should instead use {{System.nanoTime()}} for higher accuracy. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org