Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F2A51200C79 for ; Thu, 13 Apr 2017 18:19:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F15A2160BA7; Thu, 13 Apr 2017 16:19:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3F6EC160BAD for ; Thu, 13 Apr 2017 18:19:46 +0200 (CEST) Received: (qmail 611 invoked by uid 500); 13 Apr 2017 16:19:45 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 358 invoked by uid 99); 13 Apr 2017 16:19:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Apr 2017 16:19:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C506D1813FA for ; Thu, 13 Apr 2017 16:19:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4QM16-0Pvtf0 for ; Thu, 13 Apr 2017 16:19:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4EF2F61F89 for ; Thu, 13 Apr 2017 16:19:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B7DCFE0D65 for ; Thu, 13 Apr 2017 16:19:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DF65C2407B for ; Thu, 13 Apr 2017 16:19:41 +0000 (UTC) Date: Thu, 13 Apr 2017 16:19:41 +0000 (UTC) From: "Inigo Goiri (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-11546) Federation Router RPC server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 13 Apr 2017 16:19:47 -0000 [ https://issues.apache.org/jira/browse/HDFS-11546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Inigo Goiri updated HDFS-11546: ------------------------------- Attachment: HDFS-11546-HDFS-10467-005.patch Tackled [~chris.douglas] comments: * Fields made final * Fixed {{RemoteLocationContext#equals}}. * Changed locking model and other fixes in {{ConnectionPool}}. * {{ConnectionManager}} to use {{ScheduledThreadPoolExecutor}}. * {{ConnectionPoolId}} to index connection pools instead of {{String}}. Open issues: * How do we link to HADOOP-12077 for {{RouterRpcClient#invokeSequential}} and {{RouterRpcClient#invokeConcurrent}}? Do I extend the comment there? The current support is basic and it could be extended to mimic HADOOP-12077 in a subsequent JIRA. * {{RouterRpcServer}} there are a couple methods that should be reviewed, for example, {{create()}} and {{getListing()}}. * What kind of documentation would we add for the TODOs in {{RouterRpcServer}}? * The values in {{hdfs-site.xml}} are similar to those for the Namenode. I can add some rule of thumb there for setting them though. I've been testing these at medium/large scale but I'd like to leave it baking for a week at least to be confident on the performance of these changes. In the meanwhile, we can continue with the review. > Federation Router RPC server > ---------------------------- > > Key: HDFS-11546 > URL: https://issues.apache.org/jira/browse/HDFS-11546 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Affects Versions: HDFS-10467 > Reporter: Inigo Goiri > Assignee: Inigo Goiri > Attachments: HDFS-11546-HDFS-10467-000.patch, HDFS-11546-HDFS-10467-001.patch, HDFS-11546-HDFS-10467-002.patch, HDFS-11546-HDFS-10467-003.patch, HDFS-11546-HDFS-10467-004.patch, HDFS-11546-HDFS-10467-005.patch > > > RPC server side of the Federation Router implements ClientProtocol. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org