Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 5 Apr 2017 23:54:41 +0000 (UTC)
From: "Xiaobing Zhou (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13037174.1485205532000.218489.1491436481694@Atlassian.JIRA>
In-Reply-To: <JIRA.13037174.1485205532000@Atlassian.JIRA>
References: <JIRA.13037174.1485205532000@Atlassian.JIRA> <JIRA.13037174.1485205532208@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11362) Storage#shouldReturnNextDir should
 check for null dirType
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 05 Apr 2017 23:54:47 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958060#comment-15958060 ] 

Xiaobing Zhou commented on HDFS-11362:
--------------------------------------

The patch looks good, thanks [~hkoneru].

> Storage#shouldReturnNextDir should check for null dirType
> ---------------------------------------------------------
>
>                 Key: HDFS-11362
>                 URL: https://issues.apache.org/jira/browse/HDFS-11362
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Minor
>         Attachments: HDFS-11362.000.patch
>
>
> _Storage#shouldReturnNextDir_ method checks if the next Storage directory is of the same type us dirType.
> {noformat}
>     private boolean shouldReturnNextDir() {
>       StorageDirectory sd = getStorageDir(nextIndex);
>       return (dirType == null || sd.getStorageDirType().isOfType(dirType)) &&
>           (includeShared || !sd.isShared());
>     }
> {noformat}
> There is a possibility that sd.getStorageDirType() returns null (default dirType is null). Hence, before checking for type match, we should make sure that the value returned by sd.getStorageDirType() is not null.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org