Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 5 Apr 2017 20:26:41 +0000 (UTC)
From: "Xiaoyu Yao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13020185.1478893322000.214906.1491424001648@Atlassian.JIRA>
In-Reply-To: <JIRA.13020185.1478893322000@Atlassian.JIRA>
References: <JIRA.13020185.1478893322000@Atlassian.JIRA> <JIRA.13020185.1478893322527@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11131)
 TestThrottledAsyncChecker#testCancellation is flaky
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 05 Apr 2017 20:26:47 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957584#comment-15957584 ] 

Xiaoyu Yao commented on HDFS-11131:
-----------------------------------

Thanks [~arpitagarwal] for reporting and posting the fix. The patch v02 looks good to me. I just have one minor question. 
Great catch that fixes the order of executor shutdown. That looks good. Can we keep the original logic on executorService? +1 after that.

{code}
   if (!executorService.awaitTermination(timeout, timeUnit)) {
      // Interrupt executing tasks and wait again.
      executorService.shutdownNow();
      executorService.awaitTermination(timeout, timeUnit);
    }
{code}

> TestThrottledAsyncChecker#testCancellation is flaky
> ---------------------------------------------------
>
>                 Key: HDFS-11131
>                 URL: https://issues.apache.org/jira/browse/HDFS-11131
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-11131.01.patch, HDFS-11131.02.patch
>
>
> This test failed in a few precommit runs. e.g.
> https://builds.apache.org/job/PreCommit-HDFS-Build/18952/testReport/org.apache.hadoop.hdfs.server.datanode.checker/TestThrottledAsyncChecker/testCancellation/


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org