hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11718) DFSStripedOutputStream hsync/hflush should not throw UnsupportedOperationException
Date Fri, 28 Apr 2017 19:08:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989307#comment-15989307
] 

Lei (Eddy) Xu commented on HDFS-11718:
--------------------------------------

Thanks for the patch, [~manojg].  It LGTM. +1 pending for jenkins and after addressing small
nits.

* Can we use {{try-resource}} for {{FSDataOutputStream}} used in the test.
* Please add comments to the test as a reference, since this JIRA is a hot fix. 

Thanks!


> DFSStripedOutputStream hsync/hflush should not throw UnsupportedOperationException
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-11718
>                 URL: https://issues.apache.org/jira/browse/HDFS-11718
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>            Priority: Blocker
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-11644.01.patch
>
>
> This is a clone bug of HDFS-11644 to provide a quick fix while a proper fix is being
discussed and developed. The quick fix here would be to just turn {{DFSStripedOutputStream#hsync()/hflush()}}
as a no-op instead of throwing UnsupportedOperationException. 
>   @Override
>   public void hflush() {
>     throw new UnsupportedOperationException();
>   }
>   @Override
>   public void hsync() {
>     throw new UnsupportedOperationException();
>   }
> For more details please refer to the comments in HDFS-11644.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message