hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11709) StandbyCheckpointer should handle an non-existing legacyOivImageDir gracefully
Date Thu, 27 Apr 2017 13:29:04 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Erik Krogen updated HDFS-11709:
    Attachment: HDFS-11709.000.patch

Attaching v000 patch that catches {{IOExceptions}} thrown by {{saveLegacyOIVImage}} and logs
an error but continues with the rest of the checkpointing process.

> StandbyCheckpointer should handle an non-existing legacyOivImageDir gracefully
> ------------------------------------------------------------------------------
>                 Key: HDFS-11709
>                 URL: https://issues.apache.org/jira/browse/HDFS-11709
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, namenode
>    Affects Versions: 2.6.1
>            Reporter: Zhe Zhang
>            Assignee: Erik Krogen
>            Priority: Critical
>         Attachments: HDFS-11709.000.patch
> In {{StandbyCheckpointer}}, if the legacy OIV directory is not properly created, or was
deleted for some reason (e.g. mis-operation), all checkpoint ops will fall. Not only the ANN
won't receive new fsimages, the JNs will get full with edit log files, and cause NN to crash.
> {code}
>       // Save the legacy OIV image, if the output dir is defined.
>       String outputDir = checkpointConf.getLegacyOivImageDir();
>       if (outputDir != null && !outputDir.isEmpty()) {
>         img.saveLegacyOIVImage(namesystem, outputDir, canceler);
>       }
> {code}
> It doesn't make sense to let such an unimportant part (saving OIV) abort all checkpoints
and cause NN crash (and possibly lose data).

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message