hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11689) New exception thrown by (private) DFSClient API isHDFSEncryptionEnabled broke hacky hive code
Date Fri, 21 Apr 2017 17:09:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979082#comment-15979082
] 

Yongjun Zhang commented on HDFS-11689:
--------------------------------------

Thanks [~steve_l] and [~daryn].

I moved the jira to hdfs project. About "adding @Deprecated to the method", my understanding
is that this method is not deprecated. It's hive's mistake to access DFSClient which is private
to hadoop. Do we want to make the method deprecate?


> New exception thrown by (private) DFSClient API isHDFSEncryptionEnabled broke hacky hive
code 
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11689
>                 URL: https://issues.apache.org/jira/browse/HDFS-11689
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha3, 2.8.1
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-14333.001.patch, HADOOP-14333.002.patch, HADOOP-14333.003.patch
>
>
> Though Hive should be fixed not to access DFSClient which is private to HADOOP, removing
the throws added by HADOOP-14104 is a quicker solution to unblock hive.
> Hive code
> {code}
> private boolean isEncryptionEnabled(DFSClient client, Configuration conf) {
>   try {
>     DFSClient.class.getMethod("isHDFSEncryptionEnabled");
>   } catch (NoSuchMethodException e) {
>     // the method is available since Hadoop-2.7.1
>     // if we run with an older Hadoop, check this ourselves
>     return !conf.getTrimmed(DFSConfigKeys.DFS_ENCRYPTION_KEY_PROVIDER_URI, "").isEmpty();
>   }
>   return client.isHDFSEncryptionEnabled();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message