hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11652) Improve ECSchema and ErasureCodingPolicy toString, hashCode, equals
Date Sun, 16 Apr 2017 11:44:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970349#comment-15970349
] 

Rakesh R commented on HDFS-11652:
---------------------------------

Thanks [~andrew.wang] for the improvement. Just one suggestion, apart from that it looks good
to me.

In tests, please include {{Assert.fail}} for the NPE, IllegalArgumentException conditions
like below.
{code}
   try {
        // source code to verify
        Assert.fail("Fails with the given message");
    } catch (NullPointerException e) {
    }
{code}

> Improve ECSchema and ErasureCodingPolicy toString, hashCode, equals
> -------------------------------------------------------------------
>
>                 Key: HDFS-11652
>                 URL: https://issues.apache.org/jira/browse/HDFS-11652
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>            Priority: Minor
>         Attachments: HDFS-11652.001.patch, HDFS-11652.002.patch, HDFS-11652.003.patch
>
>
> Some small cleanups to these methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message