hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mukul Kumar Singh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11649) Ozone: SCM: CLI: Add shell code placeholder classes
Date Tue, 18 Apr 2017 03:19:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972059#comment-15972059
] 

Mukul Kumar Singh commented on HDFS-11649:
------------------------------------------

[~vagarychen], the patch looks good. Some minor comments

1) 1024L*1024*1024 can be replaced with OzoneConsts.GB
{code}
+    ContainerOperationClient.setContainerSizeB(containerSizeGB*1024L*1024*1024);
+    InetSocketAddress address = new InetSocketAddress(scmAddress, scmPort);
{code}

2) Also an extra check should be added to the testNonExistCommand, to check that the help
is printed correctly. 

> Ozone: SCM: CLI:  Add shell code placeholder classes
> ----------------------------------------------------
>
>                 Key: HDFS-11649
>                 URL: https://issues.apache.org/jira/browse/HDFS-11649
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-11649-HDFS-7240.001.patch, HDFS-11649-HDFS-7240.002.patch,
HDFS-11649-HDFS-7240.003.patch, HDFS-11649-HDFS-7240.004.patch, HDFS-11649-HDFS-7240.005.patch,
HDFS-11649-HDFS-7240.006.patch
>
>
> HDFS-11470 has outlined how the SCM CLI would look like. Based on the design, this JIRA
adds the basic placeholder classes for all commands to be filled in.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message