hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karan Mehta (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-11622) TraceId hardcoded to 0 in DataStreamer, correlation between multiple spans is lost
Date Tue, 04 Apr 2017 22:22:41 GMT
Karan Mehta created HDFS-11622:
----------------------------------

             Summary: TraceId hardcoded to 0 in DataStreamer, correlation between multiple
spans is lost
                 Key: HDFS-11622
                 URL: https://issues.apache.org/jira/browse/HDFS-11622
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: tracing
            Reporter: Karan Mehta


In the {{run()}} method of {{DataStreamer}} class, the following code is written. {{parents\[0\]}}
refer to the {{spanId}} of the parent span.
{code}
              one = dataQueue.getFirst(); // regular data packet
              long parents[] = one.getTraceParents();
              if (parents.length > 0) {
                     scope = Trace.startSpan("dataStreamer", new TraceInfo(0, parents[0]));
                // TODO: use setParents API once it's available from HTrace 3.2
                // scope = Trace.startSpan("dataStreamer", Sampler.ALWAYS);
                // scope.getSpan().setParents(parents);
              }
{code}

The {{scope}} starts a new TraceSpan with a traceId hardcoded to 0. Ideally it should be taken
when {{currentPacket.addTraceParent(Trace.currentSpan())}} is invoked. This JIRA is to propose
an additional long field inside the {{DFSPacket}} class which holds the parent {{traceId}}.





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message