hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SammiChen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11605) Allow user to customize and add new erasure code codecs and policies
Date Fri, 21 Apr 2017 07:56:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978249#comment-15978249

SammiChen commented on HDFS-11605:

Thanks [~HuafengWang] for working on this! I have a few comments, 
1. duplicate policy checker should check against both enabled policy and not enabled policy.
 Make sure there is no duplicated policy in the whole system. 
2.  writeUnlock("reportBadBlocks"); typo? 
3. since policy name as the key to get policy and check duplicate,  user policy name is better
created  by policy manager in backend so that the name follow the same rule used in system
4. use Preconditions.checkNotNull to check not null parameter
5. add test case in testErasureCodingConf.xml for addPolicy command
6. update document hdfserasurecoding.md

> Allow user to customize and add new erasure code codecs and policies
> --------------------------------------------------------------------
>                 Key: HDFS-11605
>                 URL: https://issues.apache.org/jira/browse/HDFS-11605
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>            Reporter: Kai Zheng
>            Assignee: Huafeng Wang
>             Fix For: 3.0.0-alpha3
>         Attachments: HDFS-11605.001.patch
> Based on the facility developed in HDFS-11604, this will develop necessary CLI cmd to
load an XML file and the results will be maintained in NameNode {{ErasureCodingPolicyManager}}
as {{USER_POLICIES}} in line with {{SYS_POLICIES}}.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message