hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11530) Use HDFS specific network topology to choose datanode in BlockPlacementPolicyDefault
Date Thu, 20 Apr 2017 09:27:04 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yiqun Lin updated HDFS-11530:
-----------------------------
    Attachment: HDFS-11530.013.patch

Thanks [~vagarychen] for providing the concrete analysis!
In my last comment, I am focus on the point in the follwoing codes:
{code}
for (StorageType type : storageTypes.keySet()) {
          ...
        }
{code}
Seemed I was misreading the comment from [~arpitagarwal], :).
Almost agree on your comment, [~vagarychen]. It's a nice catch.

Actually in the new logic, we still need to do some same logic(contained in loop). So I'd
like to make a minor adjustment that just skip the other storage type in loop and then I can
reuse the most of existing codes.

Attach the new patch. Please have a review. 


> Use HDFS specific network topology to choose datanode in BlockPlacementPolicyDefault
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-11530
>                 URL: https://issues.apache.org/jira/browse/HDFS-11530
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11530.001.patch, HDFS-11530.002.patch, HDFS-11530.003.patch,
HDFS-11530.004.patch, HDFS-11530.005.patch, HDFS-11530.006.patch, HDFS-11530.007.patch, HDFS-11530.008.patch,
HDFS-11530.009.patch, HDFS-11530.010.patch, HDFS-11530.011.patch, HDFS-11530.012.patch, HDFS-11530.013.patch
>
>
> The work for {{chooseRandomWithStorageType}} has been merged in HDFS-11482. But this
method is contained in new topology {{DFSNetworkTopology}} which is specified for HDFS. We
should update this and let {{BlockPlacementPolicyDefault}} use the new way since the original
way is inefficient.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message