hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11530) Use HDFS specific network topology to choose datanode in BlockPlacementPolicyDefault
Date Wed, 19 Apr 2017 05:20:41 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yiqun Lin updated HDFS-11530:
-----------------------------
    Attachment: HDFS-11530.012.patch

Thanks [~arpitagarwal] for the review!
{quote}
 If we fail to place a block for the first storage type then the function is guaranteed to
fail later, correct?
{quote}
I don't think so on this. The first storage type failed doesn't mean the next differential
type will failed too. We have a set of required storage type, if any one of storage type that
node contained, then this node should be a good node. The related codes:
{code}
for (Iterator<Map.Entry<StorageType, Integer>> iter = storageTypes
            .entrySet().iterator(); iter.hasNext();) {
          Map.Entry<StorageType, Integer> entry = iter.next();
          storage = chooseStorage4Block(
              chosenNode, blocksize, results, entry.getKey());
....
}
{code}

The second comment makes sense to me. I have addressed the comment in my latest patch. BTW,
I have refactor the new setting into core-default.xml.

{quote}
DatanodeDescriptor.java: The reflection checks at lines 503 and 901 also make me sad.
{quote}
I'm a little confused on this. Did you mean the following check is not a good solution?
{code}
if (getParent() instanceof DFSTopologyNodeImpl)
{code}

Attach the new patch to mainly address the comment#2. Thanks for the review.

> Use HDFS specific network topology to choose datanode in BlockPlacementPolicyDefault
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-11530
>                 URL: https://issues.apache.org/jira/browse/HDFS-11530
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11530.001.patch, HDFS-11530.002.patch, HDFS-11530.003.patch,
HDFS-11530.004.patch, HDFS-11530.005.patch, HDFS-11530.006.patch, HDFS-11530.007.patch, HDFS-11530.008.patch,
HDFS-11530.009.patch, HDFS-11530.010.patch, HDFS-11530.011.patch, HDFS-11530.012.patch
>
>
> The work for {{chooseRandomWithStorageType}} has been merged in HDFS-11482. But this
method is contained in new topology {{DFSNetworkTopology}} which is specified for HDFS. We
should update this and let {{BlockPlacementPolicyDefault}} use the new way since the original
way is inefficient.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message