hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11362) StorageDirectory should initialize a non-null default StorageDirType
Date Mon, 17 Apr 2017 15:42:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971191#comment-15971191
] 

Hudson commented on HDFS-11362:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11591/])
HDFS-11362. StorageDirectory should initialize a non-null default (xyao: rev a49fac5302128a6f5d971f5818d0fd874c3932e3)
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java


> StorageDirectory should initialize a non-null default StorageDirType
> --------------------------------------------------------------------
>
>                 Key: HDFS-11362
>                 URL: https://issues.apache.org/jira/browse/HDFS-11362
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Minor
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: HDFS-11362.000.patch, HDFS-11362.001.patch
>
>
> _Storage#shouldReturnNextDir_ method checks if the next Storage directory is of the same
type us dirType.
> {noformat}
>     private boolean shouldReturnNextDir() {
>       StorageDirectory sd = getStorageDir(nextIndex);
>       return (dirType == null || sd.getStorageDirType().isOfType(dirType)) &&
>           (includeShared || !sd.isShared());
>     }
> {noformat}
> There is a possibility that sd.getStorageDirType() returns null (default dirType is null).
Hence, before checking for type match, we should make sure that the value returned by sd.getStorageDirType()
is not null.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message