hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11131) TestThrottledAsyncChecker#testCancellation is flaky
Date Wed, 05 Apr 2017 20:26:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957584#comment-15957584
] 

Xiaoyu Yao commented on HDFS-11131:
-----------------------------------

Thanks [~arpitagarwal] for reporting and posting the fix. The patch v02 looks good to me.
I just have one minor question. 
Great catch that fixes the order of executor shutdown. That looks good. Can we keep the original
logic on executorService? +1 after that.

{code}
   if (!executorService.awaitTermination(timeout, timeUnit)) {
      // Interrupt executing tasks and wait again.
      executorService.shutdownNow();
      executorService.awaitTermination(timeout, timeUnit);
    }
{code}

> TestThrottledAsyncChecker#testCancellation is flaky
> ---------------------------------------------------
>
>                 Key: HDFS-11131
>                 URL: https://issues.apache.org/jira/browse/HDFS-11131
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-11131.01.patch, HDFS-11131.02.patch
>
>
> This test failed in a few precommit runs. e.g.
> https://builds.apache.org/job/PreCommit-HDFS-Build/18952/testReport/org.apache.hadoop.hdfs.server.datanode.checker/TestThrottledAsyncChecker/testCancellation/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message