hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10882) Federation State Store Interface API
Date Thu, 06 Apr 2017 00:24:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958092#comment-15958092
] 

Chris Douglas commented on HDFS-10882:
--------------------------------------

Just a few minor points:
* The static initialization of {{StateStoreSerializer}} could be cleaned up, and only cache
the default instance
* Could {{StateStoreSerializerPBImpl#newRecordInstance}} callers use {{ReflectionUtils#newInstance}}?
* What's the difference between a "required record" and other records? This might be clarified
in the javadocs

Otherwise +1

> Federation State Store Interface API
> ------------------------------------
>
>                 Key: HDFS-10882
>                 URL: https://issues.apache.org/jira/browse/HDFS-10882
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Jason Kace
>            Assignee: Jason Kace
>         Attachments: HDFS-10882-HDFS-10467-001.patch, HDFS-10882-HDFS-10467-002.patch,
HDFS-10882-HDFS-10467-003.patch, HDFS-10882-HDFS-10467-004.patch
>
>
> The minimal classes and interfaces required to create state store internal data APIs
using protobuf serialization.  This is a pre-requisite for higher level APIs such as the registration
API and the mount table API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message