hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9342) Erasure coding: client should update and commit block based on acknowledged size
Date Thu, 27 Apr 2017 22:52:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987835#comment-15987835
] 

Zhe Zhang commented on HDFS-9342:
---------------------------------

Sorry for the late response. Yes the main logic LGTM as well. I spent some time to go over
earlier comments, especially the [explanation|https://issues.apache.org/jira/browse/HDFS-9342?focusedCommentId=15072472&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15072472]
from Walter. Agreed this is a safe way to handle acked size.

> Erasure coding: client should update and commit block based on acknowledged size
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-9342
>                 URL: https://issues.apache.org/jira/browse/HDFS-9342
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Zhe Zhang
>            Assignee: SammiChen
>            Priority: Critical
>              Labels: hdfs-ec-3.0-nice-to-have
>         Attachments: HDFS-9342.01.patch, HDFS-9342.02.patch, HDFS-9342.03.patch, HDFS-9342.04.patch
>
>
> For non-EC files, we have:
> {code}
> protected ExtendedBlock block; // its length is number of bytes acked
> {code}
> For EC files, the size of {{DFSStripedOutputStream#currentBlockGroup}} is incremented
in {{writeChunk}} without waiting for ack. And both {{updatePipeline}} and {{commitBlock}}
are based on size of {{currentBlockGroup}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message