Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9452F200C45 for ; Tue, 28 Mar 2017 19:05:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 92C75160B89; Tue, 28 Mar 2017 17:05:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DAC9A160B6B for ; Tue, 28 Mar 2017 19:05:46 +0200 (CEST) Received: (qmail 49693 invoked by uid 500); 28 Mar 2017 17:05:45 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 49678 invoked by uid 99); 28 Mar 2017 17:05:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2017 17:05:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6C97E1A7A8E for ; Tue, 28 Mar 2017 17:05:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OhHliQxQoGlQ for ; Tue, 28 Mar 2017 17:05:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 16A105FB20 for ; Tue, 28 Mar 2017 17:05:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 303A0E06C7 for ; Tue, 28 Mar 2017 17:05:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1DA0025CEA for ; Tue, 28 Mar 2017 17:05:42 +0000 (UTC) Date: Tue, 28 Mar 2017 17:05:42 +0000 (UTC) From: "Chen Liang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11577) Combine the old and the new chooseRandom for better performance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 28 Mar 2017 17:05:47 -0000 [ https://issues.apache.org/jira/browse/HDFS-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945556#comment-15945556 ] Chen Liang commented on HDFS-11577: ----------------------------------- Thanks [~linyiqun] for adding the {{LOG.isDebugEnabled}} checking and committing the patch! > Combine the old and the new chooseRandom for better performance > --------------------------------------------------------------- > > Key: HDFS-11577 > URL: https://issues.apache.org/jira/browse/HDFS-11577 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Chen Liang > Assignee: Chen Liang > Fix For: 3.0.0-alpha3 > > Attachments: HDFS-11577.001.patch, HDFS-11577.002.patch, HDFS-11577.003.patch > > > As discussed in HDFS-11535, this JIRA adds a new function combining both the new and the old chooseRandom methods for better performance. > More specifically, when choosing a random node with storage type requirement, the combined method first tries the old method of blindly picking a random node. If this node satisfies, it is returned. Otherwise, the new chooseRandom is called, which guarantees to find a eligible node in one call (if there is one at all). -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org