Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 22986200C49 for ; Fri, 17 Mar 2017 15:44:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 20ADA160B80; Fri, 17 Mar 2017 14:44:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6B26B160B6D for ; Fri, 17 Mar 2017 15:44:48 +0100 (CET) Received: (qmail 21273 invoked by uid 500); 17 Mar 2017 14:44:47 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 21262 invoked by uid 99); 17 Mar 2017 14:44:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Mar 2017 14:44:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0035BC1962 for ; Fri, 17 Mar 2017 14:44:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id v_R5K18kyL6W for ; Fri, 17 Mar 2017 14:44:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A2DC360D08 for ; Fri, 17 Mar 2017 14:44:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4586FE08B9 for ; Fri, 17 Mar 2017 14:44:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B1A19254BB for ; Fri, 17 Mar 2017 14:44:41 +0000 (UTC) Date: Fri, 17 Mar 2017 14:44:41 +0000 (UTC) From: =?utf-8?Q?L=C3=A1szl=C3=B3_Bence_Nagy_=28JIRA=29?= To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HDFS-11542) Fix RawErasureCoderBenchmark decoding operation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Mar 2017 14:44:49 -0000 L=C3=A1szl=C3=B3 Bence Nagy created HDFS-11542: ---------------------------------------- Summary: Fix RawErasureCoderBenchmark decoding operation Key: HDFS-11542 URL: https://issues.apache.org/jira/browse/HDFS-11542 Project: Hadoop HDFS Issue Type: Sub-task Components: erasure-coding Affects Versions: 3.0.0-alpha2 Reporter: L=C3=A1szl=C3=B3 Bence Nagy Priority: Minor There are some issues with the decode operation in the *RawErasureCoderBenc= hmark.java* file. The decoding method is called like this: *decoder.decode(= decodeInputs, ERASED_INDEXES, outputs);*.=20 Using RS 6+3 configuration it could be called with these parameters correct= ly like this: *decode([ d0, NULL, d2, d3, NULL, d5, p0, NULL, p2 ], [ 1, 4,= 7 ], [ -, -, - ])*. The 1,4,7 indexes are in the *ERASED_INDEXES* array so= in the *decodeInputs* array the values at those indexes are set to NULL, a= ll other data and parity packets are present in the array. The *outputs* ar= ray's length is 3, where the d1, d4 and p1 packets should be reconstructed.= This would be the right solution. Right now this example would be called like this: *decode([ d0, d1, d2, d3,= d4, d5, -, -, - ], [ 1, 4, 7 ], [ -, -, - ])*. So it has two main problems= with the *decodeInputs* array. Firstly, the packets are not set to NULL wh= ere they should be based on the *ERASED_INDEXES* array. Secondly, it does n= ot have any parity packets for decoding. The first problem is easy to solve, the values at the proper indexes need t= o be set to NULL. The latter one is a little harder because right now multi= ple rounds of encode operations are done one after another and similarly mu= ltiple decode operations are called one by one. Encode and decode pairs sho= uld be called one after another so that the encoded parity packets can be u= sed in the *decodeInputs* array as a parameter for decode. (Of course, thei= r performance should be still measured separately.) Moreover, there is one more problem in this file. Right now it works with R= S 6+3 and the *ERASED_INDEXES* array is fixed to *[ 6, 7, 8 ]*. So the thre= e parity packets are needed to be reconstructed. This means that no real de= code performance is measured because no data packet is needed to be reconst= ructed (even if the decode works properly). Actually, only new parity packe= ts are needed to be encoded. The exact implementation depends on the underl= ying erasure coding plugin, but the point is that data packets should also = be erased to measure real decode performance. In addition to this, more RS configurations (not just 6+3) could be measure= d as well to be able to compare them. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org