Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1B460200C47 for ; Thu, 30 Mar 2017 13:43:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 19CA6160B9A; Thu, 30 Mar 2017 11:43:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 62D22160B78 for ; Thu, 30 Mar 2017 13:43:46 +0200 (CEST) Received: (qmail 76587 invoked by uid 500); 30 Mar 2017 11:43:45 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 76576 invoked by uid 99); 30 Mar 2017 11:43:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Mar 2017 11:43:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F037CC0750 for ; Thu, 30 Mar 2017 11:43:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6fIDMWiIkD2t for ; Thu, 30 Mar 2017 11:43:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 078705FCFA for ; Thu, 30 Mar 2017 11:43:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B85EE0BDD for ; Thu, 30 Mar 2017 11:43:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C8DB521DDC for ; Thu, 30 Mar 2017 11:43:41 +0000 (UTC) Date: Thu, 30 Mar 2017 11:43:41 +0000 (UTC) From: "Yiqun Lin (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11530) Use HDFS specific network topology to choose datanode in BlockPlacementPolicyDefault MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 30 Mar 2017 11:43:47 -0000 [ https://issues.apache.org/jira/browse/HDFS-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948903#comment-15948903 ] Yiqun Lin commented on HDFS-11530: ---------------------------------- Thanks [~vagarychen] for the comments. I take some time to looked into this. I picked up one other type test failure {{TestDatanodeRegistration#testChangeIpcPort}} to have a debug. The removing node operation is failed if the node registers to namenode again with different node name. Maybe this test failure leads other test failed. [~vagarychen], could you share your thought of this or we can file a new JIRA to have a track to cover this case? It seems there are still some works we should do before making {{DFSNetworkTopology}} as the default NetworkTopology {{NetworkTopology}}. In addition, I am thinking if we use {{DFSNetworkTopology}} as the default class, is that mean the other subclass of {{NetworkTopology}}(e.g. NetworkTopologyWithNodeGroup) will be not allowed used in HDFS? > Use HDFS specific network topology to choose datanode in BlockPlacementPolicyDefault > ------------------------------------------------------------------------------------ > > Key: HDFS-11530 > URL: https://issues.apache.org/jira/browse/HDFS-11530 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Affects Versions: 3.0.0-alpha2 > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Attachments: HDFS-11530.001.patch, HDFS-11530.002.patch > > > The work for {{chooseRandomWithStorageType}} has been merged in HDFS-11482. But this method is contained in new topology {{DFSNetworkTopology}} which is specified for HDFS. We should update this and let {{BlockPlacementPolicyDefault}} use the new way since the original way is inefficient. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org