Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D6970200C32 for ; Thu, 9 Mar 2017 20:33:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D56A0160B75; Thu, 9 Mar 2017 19:33:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D942160B8C for ; Thu, 9 Mar 2017 20:33:10 +0100 (CET) Received: (qmail 26375 invoked by uid 500); 9 Mar 2017 19:33:10 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 26167 invoked by uid 99); 9 Mar 2017 19:33:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 19:33:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6B492CB9B4 for ; Thu, 9 Mar 2017 19:27:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id oj7m514AS6Lo for ; Thu, 9 Mar 2017 19:27:41 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8250B5F647 for ; Thu, 9 Mar 2017 19:27:41 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D834E0BCA for ; Thu, 9 Mar 2017 19:27:39 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D422F243CE for ; Thu, 9 Mar 2017 19:27:38 +0000 (UTC) Date: Thu, 9 Mar 2017 19:27:38 +0000 (UTC) From: "Chen Liang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-11482) Add storage type demand to into DFSNetworkTopology#chooseRandom MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Mar 2017 19:33:12 -0000 [ https://issues.apache.org/jira/browse/HDFS-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Liang updated HDFS-11482: ------------------------------ Attachment: HDFS-11482.007.patch Thanks [~linyiqun] for the updated review! Post v007 patch to address the comments. Also, based on the offline discussion with [~arpitagarwal], I made a few small package change for better safety and fixing an earlier directory mistake (earlier DFS topology classes were placed in test directory...). > Add storage type demand to into DFSNetworkTopology#chooseRandom > --------------------------------------------------------------- > > Key: HDFS-11482 > URL: https://issues.apache.org/jira/browse/HDFS-11482 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Chen Liang > Assignee: Chen Liang > Attachments: HDFS-11482.001.patch, HDFS-11482.002.patch, HDFS-11482.003.patch, HDFS-11482.004.patch, HDFS-11482.005.patch, HDFS-11482.006.patch, HDFS-11482.007.patch > > > HDFS-11450 adds storage type info into network topology, with on this info we may change chooseRandom to take storage type requirement as parameter, only checking subtrees required storage type available. This way we avoid blindly picking up nodes that are not applicable. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org