hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Badger (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-11592) Closing a file has a wasteful preconditions
Date Wed, 29 Mar 2017 21:45:41 GMT

     [ https://issues.apache.org/jira/browse/HDFS-11592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Eric Badger updated HDFS-11592:
    Attachment: HDFS-11592.001.patch

Uploading patch to get rid of Preconditions and just do the expression checking up front.

> Closing a file has a wasteful preconditions
> -------------------------------------------
>                 Key: HDFS-11592
>                 URL: https://issues.apache.org/jira/browse/HDFS-11592
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: HDFS-11592.001.patch
> When a file is closed, the NN checks if all the blocks are complete. Instead of a simple
'if (!complete) throw new IllegalState(expensive-err-string)" it invokes "Preconditions.checkStatus(complete,
expensive-err-string)". The check is done in a loop for all blocks, so more blocks = more
penalty. The expensive string should only be computed when an error actually occurs. A telltale
sign is seeing this in a stacktrace:
> {noformat}
>        at java.lang.Class.getEnclosingMethod0(Native Method)
>         at java.lang.Class.getEnclosingMethodInfo(Class.java:1072)
>         at java.lang.Class.getEnclosingClass(Class.java:1272)
>         at java.lang.Class.getSimpleBinaryName(Class.java:1443)
>         at java.lang.Class.getSimpleName(Class.java:1309)
>         at org.apache.hadoop.hdfs.server.namenode.INodeFile.assertAllBlocksComplete(INodeFile.java:246)
> {noformat}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message