hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mukul Kumar Singh (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11582) Block Storage : add SCSI target access daemon
Date Fri, 31 Mar 2017 15:48:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951166#comment-15951166
] 

Mukul Kumar Singh edited comment on HDFS-11582 at 3/31/17 3:48 PM:
-------------------------------------------------------------------

[~vagarychen] Thanks for addressing the comments. I have few more minor comments

1) SCSITargetDaemon, "Configuration config = new Configuration(jscsiServerAddress);", i feel
the name of the variable here should be changed to "jscsiConfig"
{code}
+    Configuration config = new Configuration(jscsiServerAddress);
{code}
2) CBlockClientProtocolClientSideTranslatorPB.java, this is similar to what [~anu] had suggested
earlier, should we also raise an exception  if container id list is empty ?
{code}
for (CBlockClientServerProtocolProtos.ContainerIDProto containerID :
{code}

3) CBlockTargetServer.java, spelling correction in comment intalled -> installed
{code}
+ * This class extends JSCSI target server, which is a ISCSI target that can be
+ * recognized by a remote machine with ISCSI intalled.
{code}


was (Author: msingh):
[~vagarychen] Thanks for addressing the comments. I have few more minor comments

1) SCSITargetDaemon, "Configuration config = new Configuration(jscsiServerAddress);", i feel
the name of the variable here should be changed to "jscsiConfig"

2) CBlockClientProtocolClientSideTranslatorPB.java, this is similar to what [~anu] had suggested
earlier, should we also raise an exception  if container id list is empty ?
{code}
for (CBlockClientServerProtocolProtos.ContainerIDProto containerID :
{code}

3) CBlockTargetServer.java, spelling correction in comment intalled -> installed
{code}
+ * This class extends JSCSI target server, which is a ISCSI target that can be
+ * recognized by a remote machine with ISCSI intalled.
{code}

> Block Storage : add SCSI target access daemon
> ---------------------------------------------
>
>                 Key: HDFS-11582
>                 URL: https://issues.apache.org/jira/browse/HDFS-11582
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-11582-HDFS-7240.001.patch, HDFS-11582-HDFS-7240.002.patch,
HDFS-11582-HDFS-7240.003.patch, HDFS-11582-HDFS-7240.004.patch
>
>
> This JIRA adds the daemon process that exposes SCSI target access. More specifically,
with this daemon process running, any OS with SCSI can talk to this daemon process and treat
CBlock volumes as SCSI targets, in this way the user can mount the volume just like the POSIX
manner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message