hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Clampffer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11544) libhdfs++: Improve C API error reporting
Date Fri, 17 Mar 2017 19:52:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930596#comment-15930596
] 

James Clampffer commented on HDFS-11544:
----------------------------------------

No tests added because all of these functions were covered in hdfs_ext_test and test_libhdfs_mini_stress_hdfspp_test_shim_static.
 I noticed the stale error message bug while working on a patch to add a test for concurrent
reads with cancel which was hammering the minidfs cluster and getting some timeouts (hoping
to post that monday).  In this case the failure was deeper in the implementation than what
passing in a bad argument and doing a strncmp on the result would catch.

> libhdfs++: Improve C API error reporting
> ----------------------------------------
>
>                 Key: HDFS-11544
>                 URL: https://issues.apache.org/jira/browse/HDFS-11544
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-11544.HDFS-8707.000.patch
>
>
> The thread local string used for hdfsGetLastError wasn't reset between calls so it could
give stale results in confusing ways.  Now it gets reset with a placeholder that says that
<functionname> hasn't set an error string.
> Also fixed indentation that wasn't consistent + marked which functions are used by the
hdfs.h API and hdfs_ext.h API to make it easier to see when changes could break compatibility.
 Included some minor cleanup for the common case catch blocks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message