hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11534) Add counters for number of blocks in pending IBR
Date Fri, 24 Mar 2017 18:50:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940926#comment-15940926
] 

Arpit Agarwal commented on HDFS-11534:
--------------------------------------

The v3 patch looks good to me. A minor suggestion - the following call can be moved out of
the for loop (after the for loop).
{code}
      this.dnMetrics.resetBlocksInPendingIBR();
{code}
Thanks for adding the unit test.

> Add counters for number of blocks in pending IBR
> ------------------------------------------------
>
>                 Key: HDFS-11534
>                 URL: https://issues.apache.org/jira/browse/HDFS-11534
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-11534.000.patch, HDFS-11534.001.patch, HDFS-11534.002.patch,
HDFS-11534.003.patch
>
>
> IBR can be sent in batch. For the sake of diagnosis, it's helpful to understand work
load of pending queue, e.g. how many blocks as total, how many blocks in status of RECEIVING_BLOCK,
RECEIVED_BLOCK, and DELETED_BLOCK, respectively. Also the metrics can be exposed to JMX.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message