hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takanobu Asanuma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11505) Do not enable any erasure coding policies by default
Date Mon, 13 Mar 2017 11:44:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907299#comment-15907299
] 

Takanobu Asanuma commented on HDFS-11505:
-----------------------------------------

Thanks for the patch, [~manojg], and thanks for reviewing, [~andrew.wang]! I agree with Andrew's
review. One minor comment:

It seems the tests in the patch don't cover this change:
{code:title=ErasureCodingPolicyManager.java|borderStyle=solid}
if (policyName.trim().isEmpty()) {
  continue;
}
{code}

We should add the regression test to {{TestEnabledECPolicies#testValid}}.
{code}
expectValidPolicy(", " + ecPolicyName, 1);
{code}

> Do not enable any erasure coding policies by default
> ----------------------------------------------------
>
>                 Key: HDFS-11505
>                 URL: https://issues.apache.org/jira/browse/HDFS-11505
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Andrew Wang
>            Assignee: Manoj Govindassamy
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-11505.01.patch, HDFS-11505.02.patch, HDFS-11505.03.patch
>
>
> As discussed on HDFS-11314, administrators need to choose the correct set of EC policies
based on cluster size and desired fault-tolerance properties.
> This means we should not enable any EC policies by default, since any default value could
be incorrect.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message