hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11196) Ozone: Improve logging and error handling in the container layer
Date Thu, 02 Mar 2017 22:43:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893179#comment-15893179
] 

Xiaoyu Yao commented on HDFS-11196:
-----------------------------------

Thanks [~anu] for working on this. The patch looks pretty good to me. It will help us a lot
trouble shooting container layer issues in future.
I just have a few minor issues below. +1 otherwise. 

1. We seems to have an extra StorageContainerException defined in hadoop-hdfs-client/src/main/java/org/apache/hadoop/scm/container/common/helpers/StorageContainerException.java.

Can we just keep the one in hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/scm/container/common/helpers/StorageContainerException.java
only for org.apache.hadoop.scm.container.common.helpers package. 

2. NIT: StorageContainerException.java
Line 42/63/83: missing javadoc for parameter result

3. ContainerProtocolCall.java
Line 295: can we remove the TODO if this patch has taken care of the right exception thrown
issue? Ignore this comment if we still have pending work on this.
Line 300: do we need to plumb the traceID into the StorageContianerException as described
in the ticket? Looks like it is unused here.

4. ChunkUtils.java
Line 167/255: NIT: javadoc throws does not match with the code
Line 293: do we need to throw StorageContainerException with CONTAINER_INTERNAL_ERROR like
Line 214?

6. ContainerUtils.java
Line 310: NIT: javadoc throws declaration
Line 319: can we include the path in the exception message for trouble shooting?

7. KeyUtils.java
Line 67: NIT: @throws StorageContainerException
Line 82: can we include the db path and container name in the exception message for trouble
shooting?

8. ContainerManagerImpl.java
Line 102/107/156/277: throws StorageContainerException
Line 210: should we rethrow StorageContainerException here?

9. Dispatcher.java
Line 519/561: throws StorageContainerException
Line 552: Not sure if PROTOC_DECODING_ERROR is the only IOException in the try block. Can
you confirm?
Maybe adding more specific PUT_SMALLFILE_ERROR/GET_SMALLFILE_ERROR?

10. KeyManager.java
Line 50: throws StorageContainerException

> Ozone: Improve logging and error handling in the container layer
> ----------------------------------------------------------------
>
>                 Key: HDFS-11196
>                 URL: https://issues.apache.org/jira/browse/HDFS-11196
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-11196-HDFS-7240.001.patch
>
>
> Improve logging and error handling in container layer.
>  * With this change Storage Containers return StorageContainerException.
>  * Precondition checks fail with a human readable error.
>  * All failed requests are logged with traceID in the dispatcher.
>  * Returns proper error codes for corresponding failures.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message