hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaobing Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11170) Add create API in filesystem public class to support assign parameter through builder
Date Thu, 16 Mar 2017 00:02:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927221#comment-15927221

Xiaobing Zhou commented on HDFS-11170:

Thanks [~zhouwei] for the work. Some comments:
# Can we change the name (i.e. CreateBuilder) to be more self-descriptive, e.g. PathCreateBuilder
or sth like that?
# XXXBuilder#build usually returns the something being built, XXX for example, CreateBuilder#build
gives out CreateBuilder itself, which is kind of mind mismatch.
# Can you add comments to the public method FileSystem#create?

> Add create API in filesystem public class to support assign parameter through builder
> -------------------------------------------------------------------------------------
>                 Key: HDFS-11170
>                 URL: https://issues.apache.org/jira/browse/HDFS-11170
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: SammiChen
>            Assignee: Wei Zhou
>              Labels: hdfs-ec-3.0-nice-to-have
>         Attachments: HDFS-11170-00.patch, HDFS-11170-01.patch, HDFS-11170-02.patch, HDFS-11170-03.patch
> FileSystem class supports multiple create functions to help user create file. Some create
functions has many parameters, it's hard for user to exactly remember these parameters and
their orders. This task is to add builder  based create functions to help user more easily
create file. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message