hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masatake Iwasaki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7054) Make DFSOutputStream tracing more fine-grained
Date Fri, 31 Mar 2017 09:36:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950603#comment-15950603
] 

Masatake Iwasaki commented on HDFS-7054:
----------------------------------------

[~karanmehta93], I submitted the patch to reproduce the issue and the fix on HDFS-11583. I
think resetting scope to {{NullScope.INSTANCE}} on closing is the right fix.

{noformat}
-            span = scope.detach();
+            span = scope.getSpan();
{noformat}
{{detach}} should be used here to pass responsibility to close the span to ResponseProcessor
thread when the packet is acked.

bq. If the current span is detached from the scope, then calling the close method on it does
not have any effect. 

Throwing exception when {{detach}} is called on already detached TraceScope may be improvement
to avoid bug like this but HTrace 3 is no longer maintained..


> Make DFSOutputStream tracing more fine-grained
> ----------------------------------------------
>
>                 Key: HDFS-7054
>                 URL: https://issues.apache.org/jira/browse/HDFS-7054
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 2.6.0
>            Reporter: Colin P. McCabe
>            Assignee: Colin P. McCabe
>             Fix For: 2.7.0
>
>         Attachments: HDFS-7054.001.patch, HDFS-7054.002.patch, HDFS-7054.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message