Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 21 Feb 2017 23:37:44 +0000 (UTC)
From: "Andrew Wang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13044094.1487366634000.23563.1487720264246@Atlassian.JIRA>
In-Reply-To: <JIRA.13044094.1487366634000@Atlassian.JIRA>
References: <JIRA.13044094.1487366634000@Atlassian.JIRA> <JIRA.13044094.1487366634261@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11426) Refactor EC CLI to be similar to
 storage policies CLI
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 21 Feb 2017 23:37:49 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877023#comment-15877023 ] 

Andrew Wang commented on HDFS-11426:
------------------------------------

Thanks for the reviews [~tasanuma0829], [~surendrasingh], [~jojochuang]. I'm attaching a patch that should address all the review feedback, except as noted below.

bq. 2. One extra space is required after Usage: in GetECPolicyCommand#run()

I also took the opportunity to fix this missing space in StoragePolicyAdmin, hope that's okay.

bq. It could be easier to understand with a more verbose output than printing the ec policy.

Hi [~jojochuang], what would you suggest to improve the output? I did make one new change to just print the EC policy name instead of {{toString}} since I think it looks better and matches the input to {{setPolicy}}:

{noformat}
-> % hdfs ec -listPolicies
Erasure Coding Policies:
	RS-10-4-64k
	RS-3-2-64k
	RS-6-3-64k
	RS-LEGACY-6-3-64k
	XOR-2-1-64k
-> % hdfs ec -getPolicy -path hdfs:///ecdir
RS-3-2-64k
{noformat}

> Refactor EC CLI to be similar to storage policies CLI
> -----------------------------------------------------
>
>                 Key: HDFS-11426
>                 URL: https://issues.apache.org/jira/browse/HDFS-11426
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding, shell
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-11426.001.patch, HDFS-11426.002.patch, HDFS-11426.003.patch
>
>
> The {{hdfs erasurecode}} CLI is similar to {{hdfs storagepolicies}} in terms of functionality, but different in terms of behavior. Let's refactor {{ECCli}} to be more similar to the various Admin classes we already have, and also make its calling syntax mimic {{hdfs storagepolicies}} as closely as possible.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org