Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CF830200C0F for ; Thu, 2 Feb 2017 13:51:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CE08A160B61; Thu, 2 Feb 2017 12:51:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85C77160B54 for ; Thu, 2 Feb 2017 13:51:58 +0100 (CET) Received: (qmail 28840 invoked by uid 500); 2 Feb 2017 12:51:56 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 28829 invoked by uid 99); 2 Feb 2017 12:51:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 12:51:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 66037C0D2D for ; Thu, 2 Feb 2017 12:51:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2lxdmiC4SEjJ for ; Thu, 2 Feb 2017 12:51:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0F8025FDC1 for ; Thu, 2 Feb 2017 12:51:55 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7B791E041D for ; Thu, 2 Feb 2017 12:51:53 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A6C2625290 for ; Thu, 2 Feb 2017 12:51:51 +0000 (UTC) Date: Thu, 2 Feb 2017 12:51:51 +0000 (UTC) From: "Yiqun Lin (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-11385) DistCp CopyCommitter should issue warning instead of throw exception when failed to delete file. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Feb 2017 12:52:00 -0000 [ https://issues.apache.org/jira/browse/HDFS-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiqun Lin updated HDFS-11385: ----------------------------- Attachment: HDFS-11385.001.patch > DistCp CopyCommitter should issue warning instead of throw exception when failed to delete file. > ------------------------------------------------------------------------------------------------ > > Key: HDFS-11385 > URL: https://issues.apache.org/jira/browse/HDFS-11385 > Project: Hadoop HDFS > Issue Type: Bug > Components: distcp > Reporter: Yongjun Zhang > Assignee: Yiqun Lin > Attachments: HDFS-11385.001.patch > > > CopyCommiter#deleteMissing(Configuration conf) does the following in a loop for all files that need to be deleted: > {code} > if (result) { > LOG.info("Deleted " + trgtFileStatus.getPath() + " - Missing at source"); > deletedEntries++; > } else { > throw new IOException("Unable to delete " + trgtFileStatus.getPath()); > } > {code} > If for some reason there is a failure to delete a file, then an exception is thrown and no other files will be deleted. > It seems more reasonable to issue a warning here instead of throw an exception. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org