Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 2 Feb 2017 11:42:51 +0000 (UTC)
From: "Yiqun Lin (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13036541.1484915806000.16301.1486035771646@Atlassian.JIRA>
In-Reply-To: <JIRA.13036541.1484915806000@Atlassian.JIRA>
References: <JIRA.13036541.1484915806000@Atlassian.JIRA> <JIRA.13036541.1484915806544@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HDFS-11353) Improve the unit tests relevant to
 DataNode volume failure testing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Feb 2017 11:42:58 -0000


     [ https://issues.apache.org/jira/browse/HDFS-11353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yiqun Lin updated HDFS-11353:
-----------------------------
     Hadoop Flags: Reviewed
    Fix Version/s: 3.0.0-alpha3

Committed to trunk. Thanks [~manojg] and [~xiaochen] for the reviews for this!

> Improve the unit tests relevant to DataNode volume failure testing
> ------------------------------------------------------------------
>
>                 Key: HDFS-11353
>                 URL: https://issues.apache.org/jira/browse/HDFS-11353
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>             Fix For: 3.0.0-alpha3
>
>         Attachments: HDFS-11353.001.patch, HDFS-11353.002.patch, HDFS-11353.003.patch, HDFS-11353.004.patch, HDFS-11353.005.patch, HDFS-11353.006.patch
>
>
> Currently there are many tests which start with {{TestDataNodeVolumeFailure*}} frequently run timedout or failed. I found one failure test in recent Jenkins building. The stack info:
> {code}
> org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting.testSuccessiveVolumeFailures
> java.util.concurrent.TimeoutException: Timed out waiting for DN to die
> 	at org.apache.hadoop.hdfs.DFSTestUtil.waitForDatanodeDeath(DFSTestUtil.java:702)
> 	at org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting.testSuccessiveVolumeFailures(TestDataNodeVolumeFailureReporting.java:208)
> {code}
> The related codes:
> {code}
>     /*
>      * Now fail the 2nd volume on the 3rd datanode. All its volumes
>      * are now failed and so it should report two volume failures
>      * and that it's no longer up. Only wait for two replicas since
>      * we'll never get a third.
>      */
>     DataNodeTestUtils.injectDataDirFailure(dn3Vol2);
>     Path file3 = new Path("/test3");
>     DFSTestUtil.createFile(fs, file3, 1024, (short)3, 1L);
>     DFSTestUtil.waitReplication(fs, file3, (short)2);
>     // The DN should consider itself dead
>     DFSTestUtil.waitForDatanodeDeath(dns.get(2));
> {code}
> Here the code waits for the datanode failed all the volume and then become dead. But it timed out. We would be better to compare that if all the volumes are failed then wair for the datanode dead.
> In addition, we can use the method {{checkDiskErrorSync}} to do the disk error check instead of creaing files. In this JIRA, I would like to extract this logic and defined that in {{DataNodeTestUtils}}. And then we can reuse this method for datanode volme failure testing in the future.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org