Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 23 Feb 2017 03:46:44 +0000 (UTC)
From: "Xiaoyu Yao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13023982.1480402419000.39103.1487821604134@Atlassian.JIRA>
In-Reply-To: <JIRA.13023982.1480402419000@Atlassian.JIRA>
References: <JIRA.13023982.1480402419000@Atlassian.JIRA> <JIRA.13023982.1480402419533@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-11184) Ozone: SCM: Make SCM use container
 protocol
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 23 Feb 2017 03:46:55 -0000


    [ https://issues.apache.org/jira/browse/HDFS-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879801#comment-15879801 ] 

Xiaoyu Yao commented on HDFS-11184:
-----------------------------------

Thanks [~anu] for the update. The patch v6 looks good to me. 

Line 100: May need to update with the new SCM protocol.
bq. Not sure I understood this comment clearly, Do you think I should add more info in the comment ?

After reread the comments, I'm OK with the comment it as-is.

Line 241: should we update the host part when updateListenAddress() if the host is allowed to be configured as 0.0.0.0?
bq. We are just changing the config in memory, so not sure what is the right thing to do here. Please let me know your suggestions.

I think we should just use the listenAddr.getHostString() and listenAddr.getPort() to update the in-memory config.


> Ozone: SCM: Make SCM use container protocol
> -------------------------------------------
>
>                 Key: HDFS-11184
>                 URL: https://issues.apache.org/jira/browse/HDFS-11184
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-11184-HDFS-7240.001.patch, HDFS-11184-HDFS-7240.002.patch, HDFS-11184-HDFS-7240.003.patch, HDFS-11184-HDFS-7240.004.patch, HDFS-11184-HDFS-7240.005.patch, HDFS-11184-HDFS-7240.006.patch
>
>
> SCM will start using container protocol to communicate with datanodes. 
> This change introduces some test failures due to some missing features which will be moved to KSM. Will file separate JIRA to track disabled ozone tests. 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org