hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Surendra Singh Lilhore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11430) Separate class InnerNode from class NetworkTopology and make it extendable
Date Sun, 19 Feb 2017 18:59:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873798#comment-15873798
] 

Surendra Singh Lilhore commented on HDFS-11430:
-----------------------------------------------

Hi [~szetszwo],

{code} +  InnerNode.Factory factory = InnerNodeImpl.FACTORY;{code}

One doubt for this patch, Why you hardcoded factory object ?

How it will use new impl class ?

> Separate class InnerNode from class NetworkTopology and make it extendable
> --------------------------------------------------------------------------
>
>                 Key: HDFS-11430
>                 URL: https://issues.apache.org/jira/browse/HDFS-11430
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Chen Liang
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h11430_20170217.patch, h11430_20170218.patch
>
>
> The approach we will take in HDFS-11419 is to annotate topology's inner node with more
information, such that it chooses a subtree that meets storage type requirement. However,
{{InnerNode}} is not specific to HDFS, so our change should affect other components using
this class.
> This JIRA separates {{InnerNode}} out of {{NetworkTopology}} and makes it extendable.
Therefore HDFS can have it's own customized inner node class, while other services can still
have inner node as what it is right now.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message