hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Surendra Singh Lilhore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11426) Refactor EC CLI to be similar to storage policies CLI
Date Tue, 21 Feb 2017 05:04:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875370#comment-15875370
] 

Surendra Singh Lilhore commented on HDFS-11426:
-----------------------------------------------

Thanks [~andrew.wang] for patch.

Some comment from my side

1. I think {{dfs}} object should be created after {{args}} check. We can avoid extra NN connection
in case of wrong argument.

{code}
+      final DistributedFileSystem dfs = AdminHelper.getDFS(conf);
+      if (args.size() > 0) {
+        System.err.println(getName() + ": Too many arguments");
+        return 1;
+      }
{code}

2. One extra space is required after {{Usage:}} in GetECPolicyCommand#run()
{code}
+        System.err.println("Please specify the path with -path.\nUsage:" +
+            getLongUsage());
{code}

3. In all three commands {{dfs}} object should be created from the path URI. Same thing handled
for {{StoragePolicyAdmin}} in HDFS-11177

{code}
+      final DistributedFileSystem dfs = AdminHelper.getDFS(conf);
{code}
 

> Refactor EC CLI to be similar to storage policies CLI
> -----------------------------------------------------
>
>                 Key: HDFS-11426
>                 URL: https://issues.apache.org/jira/browse/HDFS-11426
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding, shell
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-11426.001.patch, HDFS-11426.002.patch
>
>
> The {{hdfs erasurecode}} CLI is similar to {{hdfs storagepolicies}} in terms of functionality,
but different in terms of behavior. Let's refactor {{ECCli}} to be more similar to the various
Admin classes we already have, and also make its calling syntax mimic {{hdfs storagepolicies}}
as closely as possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message