hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11421) Make WebHDFS' ACLs RegEx configurable
Date Fri, 24 Feb 2017 00:25:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881622#comment-15881622
] 

Xiao Chen commented on HDFS-11421:
----------------------------------

Thanks for reporting and fixing this [~qwertymaniac]!

Looks pretty good to me, just some nits in {{TestParam}}:
- Can we verify the actual value, rather than {{assertNotNull}}?
- Seems we can let the exception to throw and get logged automatically by junit, instead of
catching and assert fail.
- This exists before your patch, but maybe {{AclPermissionParam.setAclPermissionPattern(oldDomain);}}
in a {{finally}} block?

And this is my first review of a github PR, do you know how to trigger pre-commits? https://wiki.apache.org/hadoop/HowToContribute#Creating_a_GitHub_pull_request
says it's automatic, I just kicked a jenkins run and let's see if it is. :)

> Make WebHDFS' ACLs RegEx configurable
> -------------------------------------
>
>                 Key: HDFS-11421
>                 URL: https://issues.apache.org/jira/browse/HDFS-11421
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: webhdfs
>    Affects Versions: 2.6.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>
> Part of HDFS-5608 added support for GET/SET ACLs over WebHDFS. This currently identifies
the passed arguments via a hard-coded regex that mandates certain group and user naming styles.
> A similar limitation had existed before for CHOWN and other User/Group set related operations
of WebHDFS, where it was then made configurable via HDFS-11391 + HDFS-4983.
> Such configurability should be allowed for the ACL operations too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message