hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11420) Edit file should not be processed by same type processor in OfflineEditViewer
Date Fri, 17 Feb 2017 06:10:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871241#comment-15871241
] 

Yiqun Lin commented on HDFS-11420:
----------------------------------

Thanks [~surendrasingh] for the review!
{quote}
Can you add same check in OfflineImageViewer ?
{quote}
I am thinking this may be not suitable in OfflineImageViewer. Currently OfflineImageViewer
doesn't use the suffix name to judge one file is an xml file or binary file. For example,
if we use the processor {{ReverseXML}} to reconstructor the fsimage from an xml file, it will
run well whether the input file has {{.xml}} suffix or not. It only cares if the content of
the input file is XML format.

> Edit file should not be processed by same type processor in OfflineEditViewer
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-11420
>                 URL: https://issues.apache.org/jira/browse/HDFS-11420
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11420.001.patch, HDFS-11420.002.patch
>
>
> XML/Binary format edit file should not be processed by XML/Binary processor since it's
no meaning. The result is complete same with the input file. We should catch this special
case and print the error info to let users know



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message