hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-11410) Use the cache when edit logging XAttrOps
Date Tue, 14 Feb 2017 01:16:41 GMT
Xiao Chen created HDFS-11410:
--------------------------------

             Summary: Use the cache when edit logging XAttrOps
                 Key: HDFS-11410
                 URL: https://issues.apache.org/jira/browse/HDFS-11410
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: namenode
    Affects Versions: 2.5.0
            Reporter: Xiao Chen
            Assignee: Xiao Chen


[~andrew.wang] recently had a comment on HDFS-10899:
{quote}
Looks like we aren't using the op cache in FSEditLog SetXAttrOp / RemoveXAttrOp. I think this
is accidental, could you do some research? Particularly since we'll be doing a lot of SetXAttrOps,
avoiding all that object allocation would be nice. This could be a separate JIRA.
{quote}

i.e. 
{code}
    static SetXAttrOp getInstance() {
      return new SetXAttrOp();
    }
{code}
v.s.
{code}
    static AddOp getInstance(OpInstanceCache cache) {
      return (AddOp) cache.get(OP_ADD);
    }
{code}

Seems we should fix these non-caching usages.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message