hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11409) DatanodeInfo getNetworkLocation and setNetworkLocation shoud use volatile instead of synchronized
Date Tue, 14 Feb 2017 20:57:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866654#comment-15866654
] 

Xiaoyu Yao commented on HDFS-11409:
-----------------------------------

+1. I will commit the patch soon. 

> DatanodeInfo getNetworkLocation and setNetworkLocation shoud use volatile instead of
synchronized
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11409
>                 URL: https://issues.apache.org/jira/browse/HDFS-11409
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: performance
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Minor
>         Attachments: HDFS-11409.001.patch
>
>
> {{DatanodeInfo}} has synchronized methods {{getNetworkLocation}} and {{setNetworkLocation}}.
While they doing nothing more than setting and getting variable {{location}}.
> Since {{location}} is not being modified based on its current value and is independent
from any other variables. This JIRA propose to remove synchronized methods but only make {{location}}
volatile. Such that threads will not be blocked on get/setNetworkLocation.
> Thanks  [~szetszwo] for the offline disscussion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message