hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brahma Reddy Battula (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11399) Many tests fails in Windows due to injecting disk failures
Date Thu, 09 Feb 2017 11:58:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859406#comment-15859406
] 

Brahma Reddy Battula commented on HDFS-11399:
---------------------------------------------

[~linyiqun] thanks for reporting, change looks good to me. 

After this change {{assumeNotWindows();}} not require in following methods,,,can we remove
.? and can confirm about test failure..?

TestDataNodeVolumeFailure#testFailedVolumeBeingRemovedFromDataNode
TestDataNodeHotSwapVolumes#testDirectlyReloadAfterCheckDiskError
TestDataNodeVolumeFailureToleration#testConfigureMinValidVolumes
TestDataNodeVolumeFailure#testUnderReplicationAfterVolFailure

> Many tests fails in Windows due to injecting disk failures
> ----------------------------------------------------------
>
>                 Key: HDFS-11399
>                 URL: https://issues.apache.org/jira/browse/HDFS-11399
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>         Attachments: HDFS-11399.001.patch
>
>
> Found many tests run failed in Windows due to using {{DataNodeTestUtils#injectDataDirFailure}}.
One of the failure test:
> {code}
> java.io.IOException: Failed to rename D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2
to D:\work-project\hadoop\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\data\data2.origin.
> 	at org.apache.hadoop.hdfs.server.datanode.DataNodeTestUtils.injectDataDirFailure(DataNodeTestUtils.java:156)
> 	at org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean.testStorageTypeStatsWhenStorageFailed(TestBlockStatsMXBean.java:176)
> {code}
> The root cause of this is that the test method uses {{DataNodeTestUtils#injectDataDirFailure}}
to injects disk failures but however missing the compare operation {{assumeNotWindows}}. Currently
{{DataNodeTestUtils#injectDataDirFailure}} is not supported in Windows then the test fails.
> It would be better to add {{assumeNotWindows}} into {{DataNodeTestUtils#injectDataDirFailure}}
in case we forget to add this in test methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message