hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-11353) Improve the unit tests relevant to DataNode volume failure testing
Date Thu, 02 Feb 2017 11:43:51 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849821#comment-15849821
] 

Yiqun Lin edited comment on HDFS-11353 at 2/2/17 11:43 AM:
-----------------------------------------------------------

The failure test is not related. Committed to trunk. Thanks [~manojg] and [~xiaochen] for
the reviews on this!


was (Author: linyiqun):
Committed to trunk. Thanks [~manojg] and [~xiaochen] for the reviews for this!

> Improve the unit tests relevant to DataNode volume failure testing
> ------------------------------------------------------------------
>
>                 Key: HDFS-11353
>                 URL: https://issues.apache.org/jira/browse/HDFS-11353
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>             Fix For: 3.0.0-alpha3
>
>         Attachments: HDFS-11353.001.patch, HDFS-11353.002.patch, HDFS-11353.003.patch,
HDFS-11353.004.patch, HDFS-11353.005.patch, HDFS-11353.006.patch
>
>
> Currently there are many tests which start with {{TestDataNodeVolumeFailure*}} frequently
run timedout or failed. I found one failure test in recent Jenkins building. The stack info:
> {code}
> org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting.testSuccessiveVolumeFailures
> java.util.concurrent.TimeoutException: Timed out waiting for DN to die
> 	at org.apache.hadoop.hdfs.DFSTestUtil.waitForDatanodeDeath(DFSTestUtil.java:702)
> 	at org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting.testSuccessiveVolumeFailures(TestDataNodeVolumeFailureReporting.java:208)
> {code}
> The related codes:
> {code}
>     /*
>      * Now fail the 2nd volume on the 3rd datanode. All its volumes
>      * are now failed and so it should report two volume failures
>      * and that it's no longer up. Only wait for two replicas since
>      * we'll never get a third.
>      */
>     DataNodeTestUtils.injectDataDirFailure(dn3Vol2);
>     Path file3 = new Path("/test3");
>     DFSTestUtil.createFile(fs, file3, 1024, (short)3, 1L);
>     DFSTestUtil.waitReplication(fs, file3, (short)2);
>     // The DN should consider itself dead
>     DFSTestUtil.waitForDatanodeDeath(dns.get(2));
> {code}
> Here the code waits for the datanode failed all the volume and then become dead. But
it timed out. We would be better to compare that if all the volumes are failed then wair for
the datanode dead.
> In addition, we can use the method {{checkDiskErrorSync}} to do the disk error check
instead of creaing files. In this JIRA, I would like to extract this logic and defined that
in {{DataNodeTestUtils}}. And then we can reuse this method for datanode volme failure testing
in the future.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message