hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11336) [SPS]: Remove xAttrs when movements done or SPS disabled
Date Mon, 20 Feb 2017 02:43:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873974#comment-15873974
] 

Rakesh R commented on HDFS-11336:
---------------------------------

Thanks [~yuanbo] for the work. I've few comments, please take a look at the below points.
# Can we remove xattr only after the successful movement like below. Presently you are removing
outside if/else and this could remove the xattr even for the partial movement, right?
{code}
            LOG.info("Blocks storage movement is SUCCESS for the track id: {}"
                + " reported from co-ordinating datanode. But the trackID "
                + "doesn't exists in storageMovementAttemptedItems list",
                 storageMovementAttemptedResult.getTrackId());
            // Remove xattr for the track id.
            namesystem.getFSDirectory().removeSatisfyXattr(
                storageMovementAttemptedResult.getTrackId());
{code}
# Could you change the log message like, {{"BlocksStorageMovementAttemptResultMonitor thread
received exception and exiting."}} and rename object reference {{ie}} to {{e}}.
{code}
-        } catch (InterruptedException ie) {
+        } catch (Exception ie) {
           LOG.info("BlocksStorageMovementAttemptResultMonitor thread "
               + "is interrupted.", ie);
{code}
# Can we replace sleeping with the the way you have explicitly checking the existence of xattr
in {{testDropSPS}}.
{code}
+      // Make sure that satisfy xattr has been removed.
+      Thread.sleep(minCheckTimeout);
{code}
Probably, you could do this in a while loop like,
{code}
while(retry){
   // code check xattr and break on success condition.
   // ...
   // ...
   Thread.sleep(250);
}
{code}

> [SPS]: Remove xAttrs when movements done or SPS disabled
> --------------------------------------------------------
>
>                 Key: HDFS-11336
>                 URL: https://issues.apache.org/jira/browse/HDFS-11336
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Yuanbo Liu
>            Assignee: Yuanbo Liu
>         Attachments: HDFS-11336-HDFS-10285.001.patch, HDFS-11336-HDFS-10285.002.patch
>
>
> 1. When we finish the movement successfully, we should clean Xattrs.
> 2. When we disable SPS dynamically, we should clean Xattrs



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message