hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled
Date Tue, 07 Feb 2017 23:21:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857016#comment-15857016
] 

Andrew Wang commented on HDFS-11210:
------------------------------------

LGTM overall, I think we can just commit this as is if you want.

* IMO making the # of locks configurable is optional. The ideal number is typically a multiple
of the # of cores, and 16 seems like a very reasonable default considering we also typically
don't have that many keys.
* Noticed you changed indexFor from modulo to a mask. What was the reason for this? The masking
only works when the array size is a power of 2.

> Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys
after a key is rolled
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11210
>                 URL: https://issues.apache.org/jira/browse/HDFS-11210
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: encryption, kms
>    Affects Versions: 2.6.5
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HDFS-11210.01.patch, HDFS-11210.02.patch, HDFS-11210.03.patch, HDFS-11210.04.patch,
HDFS-11210.05.patch
>
>
> To support re-encrypting EDEK, we need to make sure after a key is rolled, no old version
EDEKs are used anymore. This includes various caches when generating EDEK.
> This is not true currently, simply because no such requirements / necessities before.
> This includes
> - Client Provider(s), and corresponding cache(s).
> When LoadBalancingKMSCP is used, we need to clear all KMSCPs.
> - KMS server instance(s), and corresponding cache(s)
> When KMS HA is configured with multiple KMS instances, only 1 will receive the {{rollNewVersion}}
request, we need to make sure other instances are rolled too.
> - The Client instance inside NN(s), and corresponding cache(s)
> When {{hadoop key roll}} is succeeded, the client provider inside NN should be drained
too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message