hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled
Date Fri, 24 Feb 2017 18:48:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883306#comment-15883306
] 

Akira Ajisaka commented on HDFS-10620:
--------------------------------------

Hi [~jzhuge], would you give binding +1 for the patch?

> StringBuilder created and appended even if logging is disabled
> --------------------------------------------------------------
>
>                 Key: HDFS-10620
>                 URL: https://issues.apache.org/jira/browse/HDFS-10620
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.6.4
>            Reporter: Staffan Friberg
>            Assignee: Staffan Friberg
>             Fix For: 3.0.0-alpha3
>
>         Attachments: HDFS-10620.001.patch, HDFS-10620.002.patch, HDFS-10620-branch-2.01.patch
>
>
> In BlockManager.addToInvalidates the StringBuilder is appended to during the delete even
if logging isn't active.
> Could avoid allocating the StringBuilder as well, but not sure if it is really worth
it to add null handling in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message