hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-10219) Change the default value for dfs.namenode.reconstruction.pending.timeout-sec from -1 to 300
Date Sat, 04 Feb 2017 07:45:51 GMT

     [ https://issues.apache.org/jira/browse/HDFS-10219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yiqun Lin updated HDFS-10219:
-----------------------------
    Attachment: HDFS-10219.003.patch

Thanks [~ajisakaa] for taking a look. The comment makes sense for me. New patch attached to
address the comment.

> Change the default value for dfs.namenode.reconstruction.pending.timeout-sec from -1
to 300
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10219
>                 URL: https://issues.apache.org/jira/browse/HDFS-10219
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Akira Ajisaka
>            Assignee: Yiqun Lin
>            Priority: Minor
>         Attachments: HDFS-10219.001.patch, HDFS-10219.002.patch, HDFS-10219.003.patch
>
>
> The default value for "dfs.namenode.replication.pending.timeout-sec" ({{DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_DEFAULT}})
is -1, but the timeout is 5 minutes by default.
> {code:title=BlockManager.java}
>     pendingReplications = new PendingReplicationBlocks(conf.getInt(
>       DFSConfigKeys.DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_KEY,
>       DFSConfigKeys.DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_DEFAULT) * 1000L);
> {code}
> {code:title=PendingReplicationBlocks.java}
>   private long timeout = 5 * 60 * 1000;
>   private final static long DEFAULT_RECHECK_INTERVAL = 5 * 60 * 1000;
>   PendingReplicationBlocks(long timeoutPeriod) {
>     if ( timeoutPeriod > 0 ) {
>       this.timeout = timeoutPeriod;
>     }
>     pendingReplications = new HashMap<>();
>     timedOutItems = new ArrayList<>();
>   }
> {code}
> I'm thinking we can change {{DFS_NAMENODE_REPLICATION_PENDING_TIMEOUT_SEC_DEFAULT}} from
-1 to 300 for improving readability.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message