Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8B5F200C18 for ; Sat, 7 Jan 2017 00:50:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E7430160B48; Fri, 6 Jan 2017 23:50:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3DE96160B49 for ; Sat, 7 Jan 2017 00:50:00 +0100 (CET) Received: (qmail 50060 invoked by uid 500); 6 Jan 2017 23:49:59 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 49900 invoked by uid 99); 6 Jan 2017 23:49:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jan 2017 23:49:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 02C192C03DE for ; Fri, 6 Jan 2017 23:49:59 +0000 (UTC) Date: Fri, 6 Jan 2017 23:49:59 +0000 (UTC) From: "Arpit Agarwal (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11299) Support multiple Datanode File IO hooks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 06 Jan 2017 23:50:01 -0000 [ https://issues.apache.org/jira/browse/HDFS-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806199#comment-15806199 ] Arpit Agarwal commented on HDFS-11299: -------------------------------------- Thanks for this improvement [~hanishakoneru]. Comments below: # FaultInjectorFileIoEvents#beforeMetadataOp and FaultInjectorFileIoEvents#beforeFileIo can return void. # We can just remove FileIoProvider#getStatistics, also FaultInjectorFileIoEvents#getStatistics and Datanode#getFileIoProviderStatistics. # We should keep the DiskChecker invocation out of ProfilingFileIoEvents. One way is to add a failure handler in FileIoProvider which invokes diskchecker then invokes ProfilingFileIoEvents#onFailure. # Minor: The config key names can be simplified. e.g. {{dfs.datanode.fileio.events.enabled.profiling}} ==> {{dfs.datanode.enable.fileio.profiling}}. Looks good otherwise. > Support multiple Datanode File IO hooks > --------------------------------------- > > Key: HDFS-11299 > URL: https://issues.apache.org/jira/browse/HDFS-11299 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Reporter: Hanisha Koneru > Assignee: Hanisha Koneru > Attachments: HDFS-11299.000.patch > > > HDFS-10958 introduces instrumentation hooks around DataNode disk IO and HDFS-10959 adds support for profiling hooks to expose latency statistics. > Instead of choosing only one hook using Config parameters, we want to add two separate hooks - one for profiling and one for fault injection. The fault injection hook will be useful for testing purposes. > This jira only introduces support for fault injection hook. The implementation for that will come later on. > Also, now Default and Counting FileIOEvents would not be needed as we can control enabling the profiling and fault injection hooks using config parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org